Irssi core bugs

Notice: Undefined index: tasklist_type in /var/www/ : eval()'d code on line 85 Notice: Undefined index: tasklist_type in /var/www/ : eval()'d code on line 90
  • Status Unconfirmed
  • Percent Complete
  • Task Type Bug Report
  • Category core
  • Assigned To No-one
  • Operating System Linux
  • Severity Low
  • Priority Normal
  • Reported Version irssi 0.8.15
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 0
  • Private No
Attached to Project: Irssi core bugs
Opened by William Pitcock (nenolod) - 2010-04-18

FS#749 - [patch] make xirssi work with latest SVN

Attached is a patch which makes xirssi work again.

This task does not depend on any other tasks.

Wouter Coekaerts (coekie)
Sunday, 18 April 2010, 12:43 GMT
Thanks for the patch. Can you give some more explanation about what this patch is changing?
* It seems to remove the icons for op/halfop/voice. Why?
* It uncomments font-related things, and changes "fixed 10" in "Monospace 10". Is that a switch to another font, or is it really unbreaking things?
* it comments the "if (flags & GUI_PRINT_FLAG_MONOSPACE)", does that mean everything shown in monospace now?
William Pitcock (nenolod)
Tuesday, 20 April 2010, 08:05 GMT
the op/halfop/voice icons (infact, all PNG icons) are corrupted, so I disabled them for the time being.

the font changes are mostly experimental and can be ignored, however, it only makes the irssi textgrid widget monospace, which it probably *should* be, given the fact that themes require monospace sometimes to look correctly.
William Pitcock (nenolod)
Tuesday, 20 April 2010, 08:16 GMT
the remainder of the patch is mostly chasing irssi API changes.
Wouter Coekaerts (coekie)
Tuesday, 20 April 2010, 08:16 GMT
If themes assume monospace, they should be fixed. Maybe it could be a setting in xirssi; but removing the ability to have non-monospace fonts just because some themes assume it is a bad move. (Btw, xirssi isn't the only one showing irssi output in non-monospace font; my experimental webssi also does it. So I really don't want to drop that feature in irssi).

So what remains is some build-fixes, and the icons. Any idea why they are corrupted (they used to work...)?
William Pitcock (nenolod)
Wednesday, 21 April 2010, 15:17 GMT
I think they were corrupted in the SVN conversion. If the CVS repository is still around it may be possible to recover the images.
Wouter Coekaerts (coekie)
Wednesday, 21 April 2010, 20:31 GMT
For the record, as said on IRC: it was eol-style problems with the images. They had svn:eol-style native but shouldn't have had any eol-style. Fixed now.