Irssi core bugs

All the Irssi bugs should go here, please select the proper version when reporting the bug.

Please see the Irssi core http://www.irssi.org/ChangeLog for recent updates.
| Tasklist |

FS#749 - [patch] make xirssi work with latest SVN

Attached to Project: Irssi core bugs
Opened by William Pitcock (nenolod) - Sunday, 18 April 2010, 03:14 GMT+2
Task Type Bug Report
Category core
Status Unconfirmed
Assigned To No-one
Operating System Linux
Severity Low
Priority Normal
Reported Version irssi 0.8.15
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

Attached is a patch which makes xirssi work again.
   xirssi-svn.diff (8.2 KiB)
This task depends upon

Comment by Wouter Coekaerts (coekie) - Sunday, 18 April 2010, 14:43 GMT+2
Thanks for the patch. Can you give some more explanation about what this patch is changing?
* It seems to remove the icons for op/halfop/voice. Why?
* It uncomments font-related things, and changes "fixed 10" in "Monospace 10". Is that a switch to another font, or is it really unbreaking things?
* it comments the "if (flags & GUI_PRINT_FLAG_MONOSPACE)", does that mean everything shown in monospace now?
Comment by William Pitcock (nenolod) - Tuesday, 20 April 2010, 10:05 GMT+2
the op/halfop/voice icons (infact, all PNG icons) are corrupted, so I disabled them for the time being.

the font changes are mostly experimental and can be ignored, however, it only makes the irssi textgrid widget monospace, which it probably *should* be, given the fact that themes require monospace sometimes to look correctly.
Comment by William Pitcock (nenolod) - Tuesday, 20 April 2010, 10:16 GMT+2
the remainder of the patch is mostly chasing irssi API changes.
Comment by Wouter Coekaerts (coekie) - Tuesday, 20 April 2010, 10:16 GMT+2
If themes assume monospace, they should be fixed. Maybe it could be a setting in xirssi; but removing the ability to have non-monospace fonts just because some themes assume it is a bad move. (Btw, xirssi isn't the only one showing irssi output in non-monospace font; my experimental webssi also does it. So I really don't want to drop that feature in irssi).

So what remains is some build-fixes, and the icons. Any idea why they are corrupted (they used to work...)?
Comment by William Pitcock (nenolod) - Wednesday, 21 April 2010, 17:17 GMT+2
I think they were corrupted in the SVN conversion. If the CVS repository is still around it may be possible to recover the images.
Comment by Wouter Coekaerts (coekie) - Wednesday, 21 April 2010, 22:31 GMT+2
For the record, as said on IRC: it was eol-style problems with the images. They had svn:eol-style native but shouldn't have had any eol-style. Fixed now.

Loading...