- Status Closed
- Percent Complete
- Task Type Bug Report
- Category core
- Assigned To No-one
- Operating System Linux
- Severity Very Low
- Priority Normal
- Reported Version Irssi 0.8.10
- Due in Version Undecided
- Due Date Undecided
- Votes 0
- Private No
Attached to Project: Irssi core bugs
Opened by Alex Schumann (rubin) - 2007-04-10
Last edited by Jilles Tjoelker (jilles) - 2007-11-18
Opened by Alex Schumann (rubin) - 2007-04-10
Last edited by Jilles Tjoelker (jilles) - 2007-11-18
FS#490 - proxy does not relay whowas replies to clients
When connected to irssi-proxy and issuing a /whowas using (at least) undernet (ircu2.10.11.*) ircd, the whowas reply is not proxied through.
The reason seems to be that in src/irc/proxy/listen.c whowas is not setup as a proxy redirect command.
The following patch solves the problem for me (applied against 0.8.10)
-------------------------------
--- irssi-0.8.10/src/irc/proxy/listen.c 2005-12-08 11:32:46.000000000 -0600
+++ irssi-0.8.10-rubin/src/irc/proxy/listen.c 2007-04-09 23:35:21.000000000 -0500
@@ -201,21 +201,23 @@
if (strcmp(cmd, "WHO") == 0)
grab_who(client, args);
else if (strcmp(cmd, "WHOIS") == 0) {
char *p;
/* convert dots to spaces */
for (p = args; *p != '\0'; p++)
if (*p == ',') *p = ' ';
proxy_redirect_event(client, "whois", 1, args, TRUE);
- } else if (strcmp(cmd, "ISON") == 0)
+ } else if (strcmp(cmd, "WHOWAS") == 0) {
+ proxy_redirect_event(client, "whowas", 1, args, TRUE);
+ } else if (strcmp(cmd, "ISON") == 0)
proxy_redirect_event(client, "ison", 1, args, -1);
else if (strcmp(cmd, "USERHOST") == 0)
proxy_redirect_event(client, "userhost", 1, args, -1);
else if (strcmp(cmd, "MODE") == 0) {
/* convert dots to spaces */
char *slist, *str, mode, *p;
int argc;
p = strchr(args, ' ');
if (p != NULL) *p++ = '\0';
-----------------------------------------------
Thanks!
-Rubin from irc.afternet.org
The reason seems to be that in src/irc/proxy/listen.c whowas is not setup as a proxy redirect command.
The following patch solves the problem for me (applied against 0.8.10)
-------------------------------
--- irssi-0.8.10/src/irc/proxy/listen.c 2005-12-08 11:32:46.000000000 -0600
+++ irssi-0.8.10-rubin/src/irc/proxy/listen.c 2007-04-09 23:35:21.000000000 -0500
@@ -201,21 +201,23 @@
if (strcmp(cmd, "WHO") == 0)
grab_who(client, args);
else if (strcmp(cmd, "WHOIS") == 0) {
char *p;
/* convert dots to spaces */
for (p = args; *p != '\0'; p++)
if (*p == ',') *p = ' ';
proxy_redirect_event(client, "whois", 1, args, TRUE);
- } else if (strcmp(cmd, "ISON") == 0)
+ } else if (strcmp(cmd, "WHOWAS") == 0) {
+ proxy_redirect_event(client, "whowas", 1, args, TRUE);
+ } else if (strcmp(cmd, "ISON") == 0)
proxy_redirect_event(client, "ison", 1, args, -1);
else if (strcmp(cmd, "USERHOST") == 0)
proxy_redirect_event(client, "userhost", 1, args, -1);
else if (strcmp(cmd, "MODE") == 0) {
/* convert dots to spaces */
char *slist, *str, mode, *p;
int argc;
p = strchr(args, ' ');
if (p != NULL) *p++ = '\0';
-----------------------------------------------
Thanks!
-Rubin from irc.afternet.org
This task does not depend on any other tasks.
Closed by Jilles Tjoelker (jilles)
Sunday, 18 November 2007, 21:24 GMT
Reason for closing: Fixed
Additional comments about closing: fixed in r4644
Sunday, 18 November 2007, 21:24 GMT
Reason for closing: Fixed
Additional comments about closing: fixed in r4644
Tuesday, 10 April 2007, 04:35 GMT